Skip to content

Commit

Permalink
Merge pull request #10 from hyva-themes/9/change-layout-handle
Browse files Browse the repository at this point in the history
Change layout handle name to hyvareactcheckout_reactcheckout_index.xml
  • Loading branch information
rajeev-k-tomy authored Jan 14, 2022
2 parents 13571ce + 51b6076 commit a43d5f4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ Please remember this is a template. So you can name this module as you wish. The
- registration.php
- composer.json
- etc/module.xml
- Change template as per your module name at `view/frontend/layout/hyva_reactcheckout_index.xml`
- Change template as per your module name at `view/frontend/layout/hyvareactcheckout_reactcheckout_index.xml`

```
<referenceBlock name="checkout.scripts" template="Hyva_CheckoutExample::react-script.phtml" />
```
Expand Down Expand Up @@ -67,11 +67,11 @@ import useLoginFormContext from '@hyva/react-checkout/components/login/hooks/use
import {__} from '@hyva/react-checkout/i18n';
```

Note that the NPM package `@hyva/react-checkout` actually does not (yet) exist. It is a Webpack alias pointing to
Note that the NPM package `@hyva/react-checkout` actually does not (yet) exist. It is a Webpack alias pointing to
the path `vendor/hyva-themes/magento2-react-checkout/src/reactapp/src`.

## Payment Integrations
With the React Checkout, you may need to use existing payment repositories. They will work out of box with the React Checkout
With the React Checkout, you may need to use existing payment repositories. They will work out of box with the React Checkout
repository. But you may face issues when you use them inside the template. This is because it is failing to load the
relative imports. You need to use `@hyva/react-checkout` for all those non-resolving imports.

Expand Down

0 comments on commit a43d5f4

Please sign in to comment.