Add yt ELBDM derived fields #136
Conversation
|
Updated to the latest psidm branch. |
vivi235711
left a comment
vivi235711
left a comment
There was a problem hiding this comment.
Thanks for this useful tool! I've tested it with both schemes and found a few issues (see below). Overall, it looks good.
Just a reminder about this related issue:
Support FDM derived fields in yt #364
Do you think yt needs any updates related to that? I think it would be good to include basic fields like Real, Imag, and S in yt.
hsinhaoHHuang
left a comment
hsinhaoHHuang
left a comment
There was a problem hiding this comment.
@vivi235711
Thank you for the review.
I have fixed the bugs you found.
Please help me try again to see whether they are resolved when you have time.
I think once everyone agrees on the name and definition of these derived fields in this PR, we could discuss how to add them in yt.
I am not sure how to make it most user-friendly and understandable.
vivi235711
left a comment
vivi235711
left a comment
There was a problem hiding this comment.
I've tested these scripts, and they work well. The field names and definitions look good.
3 participants
Two Python scripts are added for the analysis of ELBDM simulation data.
add_ELBDM_derived_fields.py, some useful derived fields, e.g., velocity fields and energy density, in ELBDM are defined.Add_ELBDM_derived_fields(ds)on their dataset.plot_ELBDM_derived_fields.py, the slices of the derived fields are plotted as a usage demo.The names and symbols of these fields largely depend on my own conventions and are probably not formal. Any comments or suggestions are welcome and appreciated.