Casts to avoid overflow of 32-bit integers before casting to uint64 #1440
+23
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fixes ensure that the HYPRE library correctly handles large vectors and matrices without integer overflow issues when configured with 32-bit integers (HYPRE_MIXEDINT defined).
Contributor
|
@rietmann-nv Thanks for reporting the bug. We had another PR for this issue #1421 . We will merge yours to that PR, and then to |
liruipeng
approved these changes
Dec 18, 2025
liruipeng
added a commit
that referenced
this pull request
Jan 9, 2026
* fix int overflow * Casts to avoid overflow of 32-bit integers before casting to uint64 (#1440) These fixes ensure that the HYPRE library correctly handles large vectors and matrices without integer overflow issues when configured with 32-bit integers (HYPRE_MIXEDINT defined). Co-authored-by: Rui Peng Li <[email protected]> --------- Co-authored-by: Max Rietmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this issue when running larger solves on GPUs. The error was in
par_krylov_func.cThe expression
n * size * num_vectorsoverflowed, leading to undefined behavior and crashes. I found a number of other places where this could possibly happen and fixed them as well, but they are less likely because they don't have the extranparameter.