-
Notifications
You must be signed in to change notification settings - Fork 238
Fix -Wshadow warnings
#1433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix -Wshadow warnings
#1433
Changes from all commits
096d216
cc3c9da
ca2e608
86a50d7
efa6374
8b8780a
2cd1e74
2310dd0
8de82bd
d949111
48b9f5a
db2b981
16dd158
b7aa6e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -614,7 +614,6 @@ hypre_BoomerAMGDestroy( void *data ) | |
| } | ||
| if (grid_relax_type) | ||
| { | ||
| HYPRE_Int num_levels = hypre_ParAMGDataNumLevels(amg_data); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one might need to stay in as well. I would have to look at the logic here to be sure, but
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I double checked this one and the current change is fine. We're in the destructor, so |
||
| if (grid_relax_type[1] == 15 || grid_relax_type[3] == 15 ) | ||
| { | ||
| if (grid_relax_type[1] == 15) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to stay in, but with a new name like
li. It's inside an outer loop that is already usingi. In general, this simple renaming approach is the most reliable way to make these changes. I'll try to look for other potential issues like this, but you might want to take a second look as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching! This one was a real bug! Fixed