Sycl umpire #1416
Draft
Sycl umpire #1416
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorapm
reviewed
Oct 30, 2025
Comment on lines
1731
to
1738
| #if defined(HYPRE_USING_SYCL) | ||
| HYPRE_Int device_id; | ||
| hypre_GetDevice(&device_id); | ||
| hypre_sprintf(resource_name, "%s::%d", "DEVICE", device_id); | ||
| #else | ||
| const hypre_int device_id = hypre_HandleDevice(handle); | ||
| hypre_sprintf(resource_name, "%s::%d", "DEVICE", device_id); | ||
| #endif |
Contributor
There was a problem hiding this comment.
Minor reorg:
Suggested change
| #if defined(HYPRE_USING_SYCL) | |
| HYPRE_Int device_id; | |
| hypre_GetDevice(&device_id); | |
| hypre_sprintf(resource_name, "%s::%d", "DEVICE", device_id); | |
| #else | |
| const hypre_int device_id = hypre_HandleDevice(handle); | |
| hypre_sprintf(resource_name, "%s::%d", "DEVICE", device_id); | |
| #endif | |
| #if defined(HYPRE_USING_SYCL) | |
| HYPRE_Int device_id; | |
| hypre_GetDevice(&device_id); | |
| #else | |
| const hypre_int device_id = hypre_HandleDevice(handle); | |
| #endif | |
| hypre_sprintf(resource_name, "%s::%d", "DEVICE", device_id); |
Contributor
There was a problem hiding this comment.
Also, just curious... Shouldn't hypre_HandleDevice(handle); work for SYCL as well? Curious why we need to do something different for SYCL...
Contributor
Author
There was a problem hiding this comment.
The type of hypre_HandleDevice(handle) is different for sycl. It's an actual sycl device object rather than just an integer ID.
… not seem to have the intended effect.
…l no luck. Commenting this out for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add umpire support for the sycl backend.