Make log_data required in mailer.send

[mtomilov]

Refs #9288
Supersedes #9414

This is a follow-up PR to #9337 we make log_data in mailer.send a required argument which was optional to support existing in-flight messages lacking it.

Testing

• Log in as devdata_admin
• Create a reply / mention notification of devdata_user
• Observe Send email ... in the logs

[mtomilov]

autospec doesn't affect celery task send for whatever reason, will fix that in other tests as well.
celery.app.task.Task.run is what we need to emulate which is basically __wrapped__ on a decorator.
What that means that if the service code and test code are in agreement we weren't checking if the service code calls mailer.send with a correct signature.
Also can't use patch instead because of patch target has already been mocked out error.

[mtomilov]

Why we need to specifically autospec celery task
Regular decorators with wrap properly validate the signature while celery.task one does not.

from functools import wraps
from unittest.mock import create_autospec

from h.tasks.mailer import send


def f(a, b, c):
    pass


def decorator(func):
    @wraps(func)
    def wrapper(*args, **kwargs):
        return func(*args, **kwargs)

    return wrapper


if __name__ == "__main__":
    mock_send = create_autospec(send.run)  # we expect an error but without run nothing happens
    try:
        mock_send()
    except TypeError as e:
        print("error:", e)
    
    mock_f = create_autospec(decorator(f))
    try:
        mock_f()
    except TypeError as e:
        print("error:", e)