Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log_data required in mailer.send #9410

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Conversation

mtomilov
Copy link
Contributor

@mtomilov mtomilov commented Mar 20, 2025

Refs #9288

This is a follow-up PR to #9337 we make log_data in mailer.send a required argument which was optional to support existing in-flight messages lacking it.

Testing

  • Log in as devdata_admin
  • Create a reply / mention notification of devdata_user
  • Observe Send email ... in the logs

@mtomilov mtomilov force-pushed the make-log-data-required branch from e2a049e to 727a439 Compare March 20, 2025 12:09
@mtomilov mtomilov changed the title Log a message whenever an email is sent Make log_data required in mailer.send Mar 20, 2025
@mtomilov mtomilov force-pushed the make-log-data-required branch 2 times, most recently from 5ba21a2 to 332b339 Compare March 20, 2025 12:25
@mtomilov mtomilov force-pushed the log-message-when-email-sent branch 5 times, most recently from 33e498e to 37745ce Compare March 21, 2025 08:47
Base automatically changed from log-message-when-email-sent to main March 21, 2025 08:52
@mtomilov mtomilov force-pushed the make-log-data-required branch from 332b339 to 10ef142 Compare March 21, 2025 12:24
@mtomilov mtomilov merged commit c33f557 into main Mar 21, 2025
11 checks passed
@mtomilov mtomilov deleted the make-log-data-required branch March 21, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants