Remove unused group upsert API #8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API was added for our own LMS app: #5428 But the LMS app doesn't use this API anymore (and actually I'm not sure it ever did) and it doesn't look like anything else ever used it. In upcoming PRs we need to make changes to group-related APIs (for example instead of only a group's creator being able to edit/update a group, all of a group's owners and admins need to be able to). Let's first remove this unused API so we don't have to deal with updating it, especially since this API's code is entangled with other APIs that we do need to update. Slack thread: https://hypothes-is.slack.com/archives/C4K6M7P5E/p1724926065440579
seanh
force-pushed
the
remove-unused-group-upsert-api
branch
from
e38853e to
48fb691
Compare
marcospri
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API was added for our own LMS app:
#5428
But the LMS app doesn't use this API anymore (and actually I'm not sure
it ever did) and it doesn't look like anything else ever used it.
In upcoming PRs we need to make changes to group-related APIs (for
example instead of only a group's creator being able to edit/update a
group, all of a group's owners and admins need to be able to). Let's
first remove this unused API so we don't have to deal with updating it,
especially since this API's code is entangled with other APIs that we do
need to update.
Slack thread: https://hypothes-is.slack.com/archives/C4K6M7P5E/p1724926065440579