fix: ps corrupt update #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
| updates_notify.notify_one(); | ||
| } | ||
| Err(err) => { | ||
| tracing::error!(error = %err, file = %file_path.display(), "Failed to write received update"); |
Member
There was a problem hiding this comment.
Can you adjust the error message? This is both it fails to write or receive as the fixed size asynchronous reader of the streaming protocol will check received against the expected number of bytes and error if not everything was sent.
orlandohohmeier
previously approved these changes
Jan 3, 2026
orlandohohmeier
approved these changes
Jan 3, 2026
|
🎉 This PR is included in version 1.0.0-alpha.72 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an error when a worker sends gradients to the ps, we will not add the update to the list of updates and remove the corrupted file.