_remove_ timeouts #261
Draft
_remove_ timeouts #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the improved stream guratees there is no need for a time based mechanism to catch broken sends. Thus we're removing the timeouts from `SendModel`/`SendUpdate`, stopping send actions from failing due timeouts while _slowly_ but steadly sending sending. Co-Authored-By: ChatGPT <[email protected]>
Replace SSE receive with a single-shot HTTP response that returns one pointer or 204, and pass the scheduler timeout through to the bridge as an idle deadline. The bridge now handles waiting for the first item and the executor treats an empty response as a timeout. Co-Authored-By: ChatGPT <[email protected]>
Track aggregated updates to ensure `ApplyUpdate` is scheduled after broadcast, reduce idle waits to keep training progressing, and align parameter server retries with scheduler timing to avoid stalls. Co-Authored-By: ChatGPT <[email protected]>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.