chore: upgrade to otel go v1.34.0 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 61.16% 61.18% +0.02%
==========================================
Files 59 59
Lines 2688 2690 +2
==========================================
+ Hits 1644 1646 +2
Misses 964 964
Partials 80 80 ☔ View full report in Codecov by Sentry. |
varkey98
approved these changes
Feb 20, 2025
varkey98
approved these changes
Feb 24, 2025
Yeah. Or fix/ignore whichever errors can be ignored. |
varkey98
approved these changes
Feb 28, 2025
varkey98
reviewed
Feb 28, 2025
| @@ -280,6 +280,7 @@ func (bsp *batchSpanProcessor) exportSpans(ctx context.Context) error { | |||
| // | |||
| // It is up to the exporter to implement any type of retry logic if a batch is failing | |||
| // to be exported, since it is specific to the protocol and backend being sent to. | |||
| clear(bsp.batch) // Erase elements to let GC collect objects | |||
There was a problem hiding this comment.
Just for my understanding here, aren't we emptying the list anyways at the next line?
There was a problem hiding this comment.
Not quite. https://pkg.go.dev/builtin#clear. Clear maintains the length but sets the values to the zero values of the type in the slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to otel go v1.34.0