Add exporter type config option with Zipkin and OTLP #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
mohit-a21
approved these changes
Feb 23, 2021
jcchavezs
reviewed
Feb 23, 2021
config.proto
Outdated
| @@ -46,6 +46,9 @@ message Reporting { | |||
|
|
|||
| // opa describes the setting related to the Open Policy Agent | |||
| Opa opa = 4; | |||
|
|
|||
| // reporter type - zipkin or otlp. Defaults to Zipkin, in the future it will change to otlp. | |||
There was a problem hiding this comment.
How about enum instead? otherwise this becomes a whatever value thing. WE could also make it possible to support console and file.
There was a problem hiding this comment.
How about enum instead?
I will have a look at enum
WE could also make it possible to support console and file.
This can be done incrementally per use-case.
There was a problem hiding this comment.
There is this use case already #6
There was a problem hiding this comment.
Let's tackle that in a separate PR.
Signed-off-by: Pavol Loffay <[email protected]>
pavolloffay
changed the title
pavolloffay
commented
Feb 23, 2021
| @@ -25,4 +25,4 @@ Agents can be configured using environment variables: | |||
| | HT_DATA_CAPTURE_BODY_MAX_SIZE_BYTES | Maximum size of captured body in bytes. Default should be 131_072 (128 KiB). | | |||
| | HT_PROPAGATION_FORMATS | List the supported propagation formats e.g. `HT_PROPAGATION_FORMATS="B3,TRACECONTEXT"`. | | |||
| | HT_ENABLED | When `false`, disables the agent | | |||
| | HT_JAVAAGENT_FILTER_JAR_PATHS | Is the list of path to filter jars, separated by `,` | | |||
| | HT_JAVAAGENT_FILTER_JAR_PATHS | Is the list of path to filter jars, separated by `,`. | | |||
There was a problem hiding this comment.
@jcchavezs it seems that the generator did not work for reporter type
|
@jcchavezs I have added the enum and added trace to reporter since we might do metrics as well. |
jcchavezs
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Make exporter type configurable