Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: making span processor type configurable #166

Closed
wants to merge 1 commit into from

Conversation

varkey98
Copy link
Collaborator

@varkey98 varkey98 commented Oct 2, 2024

Description

Context is that aws lambdas generally can't use batchspanprocessor since there's a runtime freeze after the execution. We can use simplespanprocessor in that case so that span exportation is inline. In node/python lambdas we use tracerprovider.flush, but in case of aspnetcore lambdas we dont need a separate handler. We can use the existing automatic instrumentation, but would require a config option for the span processor.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Sorry, something went wrong.

@tim-mwangi
Copy link
Contributor

@varkey98 did you run make generate-proto generate-env-vars? I do not see changes to ENV_VARS.md

@varkey98
Copy link
Collaborator Author

varkey98 commented Oct 2, 2024

@varkey98 did you run make generate-proto generate-env-vars? I do not see changes to ENV_VARS.md

I ran it. I don't think we generate env vars for enums. It's not there for other enums as well. But pls hold on reviews, thinking of closing this pr after discussing with @prodion23

@varkey98
Copy link
Collaborator Author

varkey98 commented Oct 5, 2024

closing this pr

@varkey98 varkey98 closed this Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants