Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding proto to the go module #164

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: adding proto to the go module #164

merged 1 commit into from
Jul 18, 2024

Conversation

varkey98
Copy link
Collaborator

@varkey98 varkey98 commented Jul 18, 2024 •
edited
Loading

Description

Objective is to add a copy of the proto file to go module so that it can be used by the go module's consumers (like mirroring agent)

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

tim-mwangi
tim-mwangi approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@tim-mwangi tim-mwangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised there is no way to do this with protoc command

@varkey98 varkey98 merged commit c23ea67 into main Jul 18, 2024
2 of 3 checks passed
@varkey98 varkey98 deleted the add-proto-go-mod branch July 18, 2024 21:05
@varkey98 varkey98 mentioned this pull request Jul 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-mwangi tim-mwangi tim-mwangi approved these changes

@ryanericson ryanericson Awaiting requested review from ryanericson

@shashank11p shashank11p Awaiting requested review from shashank11p

@puneet-traceable puneet-traceable Awaiting requested review from puneet-traceable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varkey98 @tim-mwangi