Skip to content

feat: add modus run command #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JairusSW
Copy link
Member

Does what it says

@JairusSW JairusSW requested a review from a team as a code owner July 11, 2025 23:52
Copy link

linear bot commented Jul 11, 2025

Comment on lines +12 to +16
path: Args.directory({
description: "Path to app directory",
default: ".",
exists: true,
}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate that this will work if the app path is to the source code OR to the build folder. The logic should be:

  • If a build folder exists under the given path, use the wasm, json, and env files from there.
  • If not, then expect them to exist directly at the given path.

This will allow for both running locally and for copying the build folder elsewhere and running directly.

You may need to adjust stuff in the DevCommand, or copy it here.

Copy link
Member Author

@JairusSW JairusSW Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's easy enough. The main limitation here is finding the SDK version.
I suppose the order of operations for determining the SDK version might be:

  • Look for a package-lock.json in the current directory.
  • If not found, check the parent directory (../) for a package-lock.json.
  • If neither exists, fall back to using the latest version.

Alternatively, you could extract the SDK version directly from the .wasm file metadata

Thoughts?

@mattjohnsonpint mattjohnsonpint marked this pull request as draft July 15, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants