Improve code documentation and add comments for clarity#83
Merged
traderben merged 3 commits intohyperliquid-dex:masterfrom Feb 5, 2025
Merged
Improve code documentation and add comments for clarity#83traderben merged 3 commits intohyperliquid-dex:masterfrom
traderben merged 3 commits intohyperliquid-dex:masterfrom
Conversation
Contributor
patidarrahul
commented
Dec 22, 2024
patidarrahul
commented
- Enhanced the comments and documentation throughout the code.
- Clarified agent creation and order management logic.
- Added comments explaining security considerations, order placement, and cancellation processes.
- Improved readability for future developers and maintainers.
traderben
requested changes
Jan 17, 2025
Co-authored-by: Ben <[email protected]>
traderben
approved these changes
Feb 5, 2025
Contributor
|
LGTM, thanks for the additional comments |
gblack686
pushed a commit
to gblack686/hyperliquid-python-sdk
that referenced
this pull request
Jan 31, 2026
…dex#83) * Improve code documentation and add comments for clarity * Update examples/basic_agent.py Co-authored-by: Ben <[email protected]> * Update basic_agent.py --------- Co-authored-by: Ben <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.