correct documentation comments. max_gas in spot deploy is in HYPE.#180
Merged
traderben merged 1 commit intohyperliquid-dex:masterfrom Jul 23, 2025
Merged
correct documentation comments. max_gas in spot deploy is in HYPE.#180traderben merged 1 commit intohyperliquid-dex:masterfrom
traderben merged 1 commit intohyperliquid-dex:masterfrom
Conversation
Contributor
|
Thank you for the help |
gblack686
pushed a commit
to gblack686/hyperliquid-python-sdk
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
correct documentation comments in spot_deploy. max_gas in spot deploy is in terms of HYPE, not in terms of USDC, which is incorrectly stated in the doc comments.
I confirmed this by going to
https://app.hyperliquid-testnet.xyz/deploySpot, and trying to buy an auction at the current price. The price I of the auction at that time was 2935.97839953 HYPE. the action sent in the api call wasso maxGas is in terms of HYPE. not in terms of USDC.