fix ping_sender is blocked by ws.run_forever()#130
Merged
traderben merged 1 commit intohyperliquid-dex:masterfrom Feb 11, 2025
Merged
fix ping_sender is blocked by ws.run_forever()#130traderben merged 1 commit intohyperliquid-dex:masterfrom
traderben merged 1 commit intohyperliquid-dex:masterfrom
Conversation
traderben
approved these changes
Feb 11, 2025
Contributor
traderben
left a comment
traderben
left a comment
There was a problem hiding this comment.
Thanks! Great catch and I appreciate the clear title and description!
gblack686
pushed a commit
to gblack686/hyperliquid-python-sdk
that referenced
this pull request
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ws thread always will be killed after 1 minute because there's no heartbeat that is sent.
The cause is ws.run_forever() blocks ping_sender.