Add ability to debug additional registers via gdb #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
added
the
kind/enhancement
dblnz
reviewed
Aug 25, 2025
|
|
||
| // note kvm set_fpu doesn't actually set or read the mxcsr value | ||
| // https://elixir.bootlin.com/linux/v6.16/source/arch/x86/kvm/x86.c#L12229 | ||
| self.vcpu_fd.set_fpu(&fpu)?; |
There was a problem hiding this comment.
How could we change the code to set/read the mxcsr value?
There was a problem hiding this comment.
using xsave, probably should open a separate PR to do that. for this particular spot
jsturtevant
force-pushed
the
add-additional-registers
branch
3 times, most recently
from
56a2912 to
3494b3e
Compare
|
I've updated to gdb related tests to work on Windows. This does require it to be installed on the runner vm's which is in progress. Will mark ready for review once that is complete |
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
Signed-off-by: James Sturtevant <[email protected]>
jsturtevant
force-pushed
the
add-additional-registers
branch
from
3f016b8 to
6e09be9
Compare
jsturtevant
requested review from
danbugs,
ludfjig,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for reading and writing XMM and MXCSR registers in the GDB debug interface for all supported hypervisors (KVM, MSHV, and WHVP). It introduces new fields to the register structures to hold these values and implements the necessary logic to fetch and store them using each hypervisor's API.
Register structure updates:
xmm: [u128; 16]andmxcsr: u32fields to theX86_64Regsstruct to store XMM registers and MXCSR control state.Todo: