[simongdavies]

This PR replaces the use of VirtualAllocEx and VirtualFreeEx with CreateFileMapping, MapViewOfFile, UnmapViewOfFile and CloseHandle on Windows.

This enables the mapping of memory into the surrogate processes without zero copying.

There are 9 commits as part of this PR each with its own description/explanation.

[Copilot]

Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (3)

• docs/assets/hyperlight_arch.excalidraw: Language not supported
• src/hyperlight_host/src/hypervisor/hyperv_windows.rs: Evaluated as low risk
• src/hyperlight_host/src/hypervisor/hypervisor_handler.rs: Evaluated as low risk

Comments suppressed due to low confidence (3)

src/hyperlight_host/src/mem/shared_mem.rs:111

• The new behavior introduced in the Drop implementation of HostMapping should be covered by tests.

if let Err(e) = unsafe { UnmapViewOfFile(mem_mapped_address) } {

src/hyperlight_host/src/hypervisor/surrogate_process.rs:85

• There is a spelling mistake in the error message: 'drropping' should be 'dropping'.

tracing::error!("Failed to get surrogate process manager when drropping SurrogateProcess: {:?}", e);

src/hyperlight_host/src/hypervisor/surrogate_process.rs:60

• [nitpick] The variable 'mem_mapped_address' should follow Rust's naming convention and be renamed to 'memory_mapped_view_address'.

let mem_mapped_address = MEMORY_MAPPED_VIEW_ADDRESS {

[Copilot]

Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (3)

• docs/assets/hyperlight_arch.excalidraw: Language not supported
• src/hyperlight_host/src/hypervisor/hyperv_windows.rs: Evaluated as low risk
• src/hyperlight_host/src/mem/mgr.rs: Evaluated as low risk

Comments suppressed due to low confidence (4)

src/hyperlight_host/src/sandbox/uninitialized.rs:1162

• The error message should be clear and consistent. Consider rephrasing to: 'GuestBinary not found: 'some/path/that/does/not/exist': The system cannot find the path specified (os error)'.

matches!(sbox, Err(e) if e.to_string().contains("GuestBinary not found: 'some/path/that/does/not/exist': The system cannot find the path specified. (os error"))

src/hyperlight_host/src/hypervisor/surrogate_process.rs:66

• The error message should be updated to reflect the new function name UnmapViewOfFile2.

Failed to free surrogate process resources (UnmapViewOfFile2 failed): {:?}

src/hyperlight_host/src/hypervisor/surrogate_process.rs:85

• The error message should be updated to reflect the new function name return_surrogate_process.

Failed to get surrogate process manager when dropping SurrogateProcess: {:?}

src/hyperlight_host/src/hypervisor/surrogate_process.rs:64

• Ensure that the new behavior introduced by UnmapViewOfFile2 is adequately covered by tests.

if let Err(e) = unsafe { UnmapViewOfFile2(process_handle, memory_mapped_view_address, flags) } {

[marosset]

Looks good to me

[ludfjig]

LGTM!

[ludfjig]

LGTM. Regarding the HANDLE insteade of HandleWrapper, it just seemed unnecessary to have send/sync on handle when it wasn't needed, but if it's indeed in needed, or that made things more complicated feel free to change it back

[simongdavies]

LGTM. Regarding the HANDLE insteade of HandleWrapper, it just seemed unnecessary to have send/sync on handle when it wasn't needed, but if it's indeed in needed, or that made things more complicated feel free to change it back

It is needed in some places but not in the one where you pointed it out, since I have to make another small change I will check and see if there are other places where it can be removed.