back port of custom uri support for non fungible tokens #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ERC721WithData contract now supports custom token URI's on mint. - constructor now takes an optional baseURI string - new MintWithURI method that sets the URI for the provided token id Signed-off-by: Alex Shorsher <[email protected]>
Signed-off-by: Alex Shorsher <[email protected]>
- Added new TokenFactory interface for ERC165 support - Updated ERC721WithData interace to include MintWithURI Signed-off-by: Alex Shorsher <[email protected]>
`mint` and `createpool` api's now accept a `uri` parameter Signed-off-by: Alex Shorsher <[email protected]>
Signed-off-by: Alex Shorsher <[email protected]>
- only expose `uri` param on `TokenMint` - `iid` logic cleanup - better naming for cache of uri support Signed-off-by: Alex Shorsher <[email protected]>
- add short-circuit preventing unnecessary transactions Signed-off-by: Alex Shorsher <[email protected]>
Signed-off-by: Alex Shorsher <[email protected]>
Signed-off-by: Alex Shorsher <[email protected]>
Signed-off-by: Alex Shorsher <[email protected]>
shorsher
requested review from
awrichar,
peterbroadhurst,
nguyer and
dechdev
as code owners
awrichar
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
back port of #60, #61, and #64