[baseURI-fix] handle burned token uri case

Signed-off-by: David Echelberger <[email protected]>
hyperledger · Feb 2, 2022 · 7235015 · 7235015
1 parent 811c73f
commit 7235015
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 16 deletions.
diff --git a/src/tokens/tokens.service.ts b/src/tokens/tokens.service.ts
@@ -349,20 +349,23 @@ class TokenListener implements EventListener {
     contractAddress: string,
   ): Promise<string> {
     const methodABI = standardAbiMap.ERC721WithData.find(method => method.name === 'tokenURI');
-
-    const response = await lastValueFrom(
-      this.service.http.post<EthConnectReturn>(`${this.service.baseUrl}?`, {
-        headers: {
-          type: 'Query',
-        },
-        from: operator,
-        to: contractAddress,
-        method: methodABI,
-        params: [tokenIdx],
-      } as EthConnectMsgRequest),
-    );
-
-    return response.data.output;
+    try {
+      const response = await lastValueFrom(
+        this.service.http.post<EthConnectReturn>(`${this.service.baseUrl}?`, {
+          headers: {
+            type: 'Query',
+          },
+          from: operator,
+          to: contractAddress,
+          method: methodABI,
+          params: [tokenIdx],
+        } as EthConnectMsgRequest),
+      );
+      return response.data.output;
+    } catch (e) {
+      this.logger.log(`Burned tokens do not have a URI: ${e}`);
+      return '';
+    }
   }
 
   private async transformTransferEvent(

diff --git a/test/ws.e2e-spec.ts b/test/ws.e2e-spec.ts
@@ -499,7 +499,7 @@ describe('WebSocket AppController (e2e)', () => {
     });
 
     const baseUriResponse: EthConnectReturn = {
-      output: ERC721_BASE_URI,
+      output: '',
     };
 
     http.post = jest.fn(() => new FakeObservable(baseUriResponse));
@@ -552,7 +552,7 @@ describe('WebSocket AppController (e2e)', () => {
         },
         type: 'nonfungible',
         tokenIndex: '721',
-        uri: ERC721_BASE_URI,
+        uri: '', // Burned tokens have no URI
       } as TokenBurnEvent,
     };