Devnet-5: bug fixes for 7702 #8148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move common code to AbstractExtCodeOperation class Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
…llehrner/besu into feat/issue-8147/devnet5_7702_fixes
Signed-off-by: Daniel Lehrner <[email protected]>
siladu
approved these changes
Jan 22, 2025
| @@ -47,7 +47,7 @@ class CodeDelegationProcessorTest { | |||
|
|
|||
| @Mock private Transaction transaction; | |||
|
|
|||
| @Mock private DelegatedCodeService authorizedCodeService; | |||
| @Mock private CodeDelegationService authorizedCodeService; | |||
There was a problem hiding this comment.
Suggested change
| @Mock private CodeDelegationService authorizedCodeService; | |
| @Mock private CodeDelegationService delegationCodeService; |
| @@ -66,7 +66,7 @@ default Optional<Address> delegatedCodeAddress() { | |||
| * | |||
| * @return true if the account has delegated code otherwise false. | |||
| */ | |||
| default boolean hasDelegatedCode() { | |||
| default boolean hasCodeDelegation() { | |||
There was a problem hiding this comment.
very much a nit pick: I think I actually prefer hasDelegatedCode in this case, since it is clear the code is actually delegated. hasCodeDelegation could be read as "has code delegation feature but maybe it's not currently delegated"
| @@ -78,9 +78,9 @@ public interface AccountState { | |||
| /** | |||
| * The optional EVM bytecode if the account has set a 7702 code delegation. | |||
| * | |||
| * @return the delegated code (which may be empty). | |||
| * @return the code of the target account (which may be empty). | |||
There was a problem hiding this comment.
Suggested change
| * @return the code of the target account (which may be empty). | |
| * @return the code of the target account that this account delegates to (which may be empty). |
...checking my understanding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
fixes #8147
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests