Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate BlockAwareOperationTracer::traceStartBlock(BlockHeader, BlockBody, [Address]) #8121

Conversation

lu-pinto
Copy link
Contributor

PR description

I found out that BlockAwareOperationTracer::traceStartBlock(BlockHeader, BlockBody, Address) is actually not used if not from the Tracing plugin and having access to the block body before building it does not seem to make sense.

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@lu-pinto lu-pinto force-pushed the unused-traceStartBlock-method-block-body branch from 269f89b to 85c72a2 Compare January 15, 2025 11:45
@lu-pinto lu-pinto closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant