Skip to content

Commit

Permalink
remove hard coded baseFeeUpdateFraction from CancunFeeMarket & Prague…
Browse files Browse the repository at this point in the history
…FeeMarket

Signed-off-by: Daniel Lehrner <[email protected]>
  • Loading branch information
daniellehrner committed Jan 16, 2025
1 parent f439609 commit c8a6268
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package org.hyperledger.besu.ethereum.mainnet.feemarket;

import org.hyperledger.besu.config.BlobScheduleOptions;
import org.hyperledger.besu.datatypes.BlobGas;
import org.hyperledger.besu.datatypes.Wei;

Expand All @@ -26,7 +27,6 @@
public class CancunFeeMarket extends LondonFeeMarket {
private static final Logger LOG = LoggerFactory.getLogger(CancunFeeMarket.class);
protected static final BigInteger BLOB_GAS_PRICE = BigInteger.ONE;
private static final long BLOB_GAS_PRICE_UPDATE_FRACTION = 3338477;

protected final BigInteger baseFeeUpdateFraction;

Expand All @@ -41,7 +41,10 @@ public CancunFeeMarket(

public CancunFeeMarket(
final long londonForkBlockNumber, final Optional<Wei> baseFeePerGasOverride) {
this(londonForkBlockNumber, baseFeePerGasOverride, BLOB_GAS_PRICE_UPDATE_FRACTION);
this(
londonForkBlockNumber,
baseFeePerGasOverride,
BlobScheduleOptions.BlobSchedule.CANCUN_DEFAULT.getBaseFeeUpdateFraction());
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*/
package org.hyperledger.besu.ethereum.mainnet.feemarket;

import org.hyperledger.besu.config.BlobScheduleOptions;
import org.hyperledger.besu.datatypes.BlobGas;
import org.hyperledger.besu.datatypes.Wei;

Expand All @@ -23,7 +24,6 @@
import org.slf4j.LoggerFactory;

public class PragueFeeMarket extends CancunFeeMarket {
private static final long BLOB_BASE_FEE_UPDATE_FRACTION_ELECTRA = 5007716;
private static final Logger LOG = LoggerFactory.getLogger(PragueFeeMarket.class);

public PragueFeeMarket(
Expand All @@ -35,7 +35,10 @@ public PragueFeeMarket(

public PragueFeeMarket(
final long londonForkBlockNumber, final Optional<Wei> baseFeePerGasOverride) {
this(londonForkBlockNumber, baseFeePerGasOverride, BLOB_BASE_FEE_UPDATE_FRACTION_ELECTRA);
this(
londonForkBlockNumber,
baseFeePerGasOverride,
BlobScheduleOptions.BlobSchedule.PRAGUE_DEFAULT.getBaseFeeUpdateFraction());
}

@Override
Expand Down

0 comments on commit c8a6268

Please sign in to comment.