LO2302 support timeout #158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for packet timeout functionality as part of LO2302. The key changes include introducing a new SortUnrelayedPackets function in the naive strategy, updating the RelayService logic to use the sorted relay packets, and adding tests to validate timeout behavior.
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/naive-strategy.go | Added SortUnrelayedPackets method with logic to mark timeout packets and adjust packet routing based on channel order. |
| core/service.go | Updated RelayService to use the sorted relay packets for further processing. |
| chains/tendermint/query.go | Introduced QueryNextSequenceReceive along with its underlying helper functions. |
| core/chain.go | Added go:generate directive and QueryNextSequenceReceive to the Chain interface. |
| core/strategies.go | Added SortUnrelayedPackets to the StrategyI interface. |
| core/types.go | Added a new Sort field to the PacketInfo struct to support timeout sorting. |
| core/provers.go | Updated type references to use the correct ibcexported package. |
| core/service_test.go | Added and modified tests to validate the new timeout support in various scenarios. |
siburu
reviewed
Mar 25, 2025
core/chain_testmock.go
Outdated
There was a problem hiding this comment.
Since this file is used only in testing, the file name should end with _test.go, for example mock_chain_test.go.
core/types.go
Outdated
| @@ -13,6 +13,7 @@ type PacketInfo struct { | |||
| chantypes.Packet | |||
| Acknowledgement []byte `json:"acknowledgement"` | |||
| EventHeight clienttypes.Height `json:"event_height"` | |||
| Sort string `json:"sort"` | |||
There was a problem hiding this comment.
Isn't TimedOut bool (for example) a more suitable definition?
core/naive-strategy.go
Outdated
| @@ -199,6 +200,74 @@ func (st *NaiveStrategy) UnrelayedPackets(ctx context.Context, src, dst *Provabl | |||
| }, nil | |||
| } | |||
|
|
|||
| func (st *NaiveStrategy) SortUnrelayedPackets(ctx context.Context, src, dst *ProvableChain, sh SyncHeaders, rp *RelayPackets) (*RelayPackets, error) { | |||
There was a problem hiding this comment.
I think this process is not "sort", right?
For example ProcessTimeoutPackets is more straightforward.
dai1975
force-pushed
the
lo2302-timeout-2
branch
from
8b0fa62 to
bfb0b8a
Compare
added 10 commits
March 31, 2025 06:03
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
dai1975
force-pushed
the
lo2302-timeout-2
branch
from
bfb0b8a to
ffdce65
Compare
added 3 commits
March 31, 2025 07:15
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Signed-off-by: Daisuke Kanda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.