Skip to content

Deprecate choices from old voting flow #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 22, 2025

Conversation

julientinguely-da
Copy link
Contributor

fixes #925

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
@julientinguely-da julientinguely-da marked this pull request as ready for review July 18, 2025 05:42
Copy link
Contributor

@moritzkiefer-da moritzkiefer-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I'd still consider if there is a point to keeping the logic for external amulet rules. Maybe best to keep it to not blow up this PR further but create a separate tech debt to consider cleaning this up.

@julientinguely-da julientinguely-da enabled auto-merge (squash) July 21, 2025 13:35
@julientinguely-da
Copy link
Contributor Author

Maybe best to keep it to not blow up this PR further but create a separate tech debt to consider cleaning this up.

#1624

@julientinguely-da julientinguely-da merged commit bce7ed7 into main Jul 22, 2025
58 checks passed
@julientinguely-da julientinguely-da deleted the julien/925-clean-old-voting-flow branch July 22, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup after the new vote proposals are released
2 participants