-
Notifications
You must be signed in to change notification settings - Fork 24
Deprecate choices from old voting flow #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
…/925-clean-old-voting-flow
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
Signed-off-by: Julien Tinguely <[email protected]>
apps/common/src/main/scala/org/lfdecentralizedtrust/splice/util/SpliceUtil.scala
Show resolved
Hide resolved
...rg/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala
Show resolved
Hide resolved
...ala/org/lfdecentralizedtrust/splice/integration/tests/SvStateManagementIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Julien Tinguely <[email protected]>
…ulien/925-clean-old-voting-flow
Signed-off-by: Julien Tinguely <[email protected]>
AppUpgradeTest Signed-off-by: Julien Tinguely <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I'd still consider if there is a point to keeping the logic for external amulet rules. Maybe best to keep it to not blow up this PR further but create a separate tech debt to consider cleaning this up.
...rg/lfdecentralizedtrust/splice/integration/tests/BootstrapPackageConfigIntegrationTest.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Julien Tinguely <[email protected]>
…ulien/925-clean-old-voting-flow
Signed-off-by: Julien Tinguely <[email protected]>
…ulien/925-clean-old-voting-flow
|
fixes #925
Pull Request Checklist
Cluster Testing
/cluster_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n
, and mention issues worked on using#n
Merge Guidelines