-
Notifications
You must be signed in to change notification settings - Fork 24
Simonletort da/1034 from the docs site, users do not know how they can suggest changes to the docs #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fixes #1034 |
…ow-how-they-can-suggest-changes-to-the-docs' of https://github.com/simonletort-da/splice into simonletort-da/1034-From-the-docs-site,-users-do-not-know-how-they-can-suggest-changes-to-the-docs
@@ -0,0 +1,3 @@ | |||
{ | |||
"image": "ghcr.io/zombiezen/codespaces-nix" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this intended to be part of the PR, or maybe a local leftover? (I think it should not be part of the PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to get nix to run in GH Codespace. But it's not working. This is why I kept the PR as 'draft'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would remove the devcontainer file, otherwise looks good, thanks
@ray-roestenburg-da I was trying to get nix to run on GH Codespace, but I haven't been able to make it work. |
@ethancohen-da you can get inspired by this script" https://github.com/DACH-NY/canton-utility-examples/blob/main/scripts/preview-docs.sh Instructions:
|
@simonletort-da please review changes made to delpoyment.rst |
update from @ethancohen-da based on gDoc suggested in global-synchronizer-foundation/docs#20 (comment)
…anged the name of the file to overview.rst
…ow-how-they-can-suggest-changes-to-the-docs' into 731-Document-high-level-roles-and-functions-of-the-nodes-making-up-the-CN
…es-and-functions-of-the-nodes-making-up-the-CN bringing 731 changes to 1034
Pull Request Checklist
Cluster Testing
/cluster_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_test
on this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n
, and mention issues worked on using#n
Merge Guidelines