feat(castor): now castor and agents can create a did with any keys #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: goncalo-frade-iohk <[email protected]>
yshyn-iohk
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
@goncalo-frade-iohk, I'm not proficient in Swift, but your PR looks good ;)
curtis-h
reviewed
Mar 4, 2025
| case .capabilityInvocationKey: | ||
| return "capabilityInvocationKey\(index)" | ||
| return "capability-invocationKey\(index)" |
There was a problem hiding this comment.
why have these changed? is this something that needs to be mirrored in other SDKs?
There was a problem hiding this comment.
Short answer is not really defined here: https://github.com/input-output-hk/prism-did-method-spec/blob/main/w3c-spec/PRISM-method.md
Long answer: It should be defined plus it seems the examples suggest it should be like that and on the cloud agent its like that, so lets go for it as the default.
mineme0110
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
now castor and agents can create a did with any keys
This PR also fixes a bug with the issuance flow on SD-JWT.
Checklist: