This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix: BBS+ Selective Disclosure output fields mix #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes hyperledger-archives#2460 Signed-off-by: Dmitriy Kinoshenko <[email protected]>
kdimak
requested review from
sudeshrshetty,
rolsonquadras,
soluchok,
fqutishat,
llorllale and
troyronda
Codecov Report
@@ Coverage Diff @@
## main #2481 +/- ##
==========================================
+ Coverage 89.28% 89.29% +0.01%
==========================================
Files 250 250
Lines 18799 18850 +51
==========================================
+ Hits 16784 16832 +48
- Misses 1185 1187 +2
- Partials 830 831 +1
Continue to review full report at Codecov.
|
kdimak
commented
Jan 22, 2021
| @@ -484,7 +484,7 @@ func ExampleCredential_GenerateBBSSelectiveDisclosure() { | |||
| "VerifiableCredential", | |||
| "PermanentResidentCard" | |||
| ], | |||
| "issuer": "did:example:489398593", | |||
| "issuer": "did:example:b34ca6cd37bbf23", | |||
There was a problem hiding this comment.
Here we use did:example:b34ca6cd37bbf23 ID for the issuer what coincides with ID of credentialSubject.
kdimak
commented
Jan 22, 2021
| @@ -192,19 +192,7 @@ func buildDocVerificationData(docCompacted, revealDoc map[string]interface{}, | |||
| return nil, fmt.Errorf("create verify document data: %w", err) | |||
| } | |||
|
|
|||
| transformedInputDocumentStatements := make([]string, len(documentStatements)) | |||
There was a problem hiding this comment.
This code was redundant.
fqutishat
approved these changes
Jan 22, 2021
baha-ai
approved these changes
Jan 22, 2021
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Oct 18, 2021
sudeshrshetty
pushed a commit
to sudeshrshetty/aries-framework-go
that referenced
this pull request
Jan 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the input VC document has the same
idof two fields, output BBS+ Signature Proof of VC (selective disclosure) may contain invalid substituted fields.The issue is filed in json-gold library (link). It works properly at JSON-LD playground (link). So current PR provides a workaround solution - to replace duplicated IDs with generated unique IDs before JSON-LD framing and then replacing IDs back.
closes #2460
Signed-off-by: Dmitriy Kinoshenko [email protected]