Skip to content

feat: zksync verification classes#5210

Merged
paulbalaji merged 408 commits intohyperlane-xyz:mainfrom
txfusion:feat/zksync-verification-classes
May 23, 2025
Merged

feat: zksync verification classes#5210
paulbalaji merged 408 commits intohyperlane-xyz:mainfrom
txfusion:feat/zksync-verification-classes

Conversation

@mshojaei-txfusion
Copy link
Copy Markdown
Contributor

@mshojaei-txfusion mshojaei-txfusion commented Jan 20, 2025

Description

This PR adds support for ZKSync contract verification with custom compiler options. Key changes include:

  • Added ZKSyncContractVerifier class to handle ZKSync-specific contract verification
  • Extended PostDeploymentContractVerifier to support ZKSync explorer family
  • Added ZKSync-specific compiler options and types
  • Implemented constructor arguments retrieval for ZKSync contracts
  • Added utility functions for ZKSync contract verification

PR to feat/zksync-deployment-functions

Drive-by changes

  • Refactored contract verification classes to better support different types of verifications
  • Extracted common verification logic into BaseContractVerifier
  • Added verification delay times for different explorer families
  • Improved error handling and logging for verification processes

Related issues

https://linear.app/hyperlane-xyz/issue/ENG-1152

Backward compatibility

Yes - These changes are backward compatible. The existing contract verification functionality for other chains refactored with same interface.

Testing

Build passing

mortezashojaei and others added 30 commits November 28, 2024 14:46
@paulbalaji paulbalaji removed the request for review from aroralanuk April 24, 2025 14:28
Copy link
Copy Markdown
Contributor

@antigremlin antigremlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments

Comment thread typescript/sdk/src/deploy/verify/PostDeploymentContractVerifier.ts Outdated
Comment thread typescript/sdk/src/deploy/verify/ContractVerifier.ts
Comment thread typescript/sdk/src/deploy/verify/ContractVerifier.ts
Comment thread typescript/sdk/src/deploy/verify/utils.ts
Comment thread typescript/sdk/src/deploy/verify/utils.ts
Comment thread typescript/sdk/src/deploy/verify/utils.ts
Comment thread typescript/sdk/src/deploy/verify/ContractVerifier.ts Outdated
Comment thread typescript/sdk/src/deploy/verify/ZKSyncContractVerifier.ts
Comment thread typescript/sdk/src/deploy/verify/utils.ts Outdated
@ljankovic-txfusion
Copy link
Copy Markdown
Contributor

For Contract verification related logic please tag @mshojaei-txfusion

@paulbalaji paulbalaji requested a review from antigremlin May 20, 2025 18:36
Copy link
Copy Markdown
Contributor

@antigremlin antigremlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at my comment in PostDeploymentContractVerifier

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Hyperlane Tasks May 21, 2025
@paulbalaji paulbalaji closed this May 23, 2025
@paulbalaji paulbalaji reopened this May 23, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperlane Tasks May 23, 2025
@github-project-automation github-project-automation bot moved this from Done to Sprint in Hyperlane Tasks May 23, 2025
@paulbalaji paulbalaji enabled auto-merge May 23, 2025 11:57
@paulbalaji paulbalaji added this pull request to the merge queue May 23, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2025
@paulbalaji paulbalaji added this pull request to the merge queue May 23, 2025
Merged via the queue into hyperlane-xyz:main with commit 6229159 May 23, 2025
102 of 112 checks passed
@github-project-automation github-project-automation bot moved this from Sprint to Done in Hyperlane Tasks May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants