feat(client): add option to HttpConnector to enable or disable #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpInfo Add `http_info` configuration option in `Config`. Change return type of `HttpConnector` from `TcpStream` to `HttpConnection`. This gives `TcpStream` access to `Config` for setting `HttpInfo` value. BREAKING CHANGE: HttpConnector returns a `HttpConnection` instead of `TcpStream`.
|
I think you should open a new PR to submit breaking changes. |
seanmonstar
requested changes
May 24, 2022
| @@ -256,7 +274,7 @@ where | |||
| R: Resolve + Clone + Send + Sync + 'static, | |||
| R::Future: Send, | |||
| { | |||
| type Response = TcpStream; | |||
| type Response = HttpConnection; | |||
There was a problem hiding this comment.
This would be a breaking change. Can we provide the configuration without needing a new type?
|
Are you still working on it🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
http_infoconfiguration option inhttp::Config. It can be used to enable or disableHttpInfo.HttpInfois set through methods defined onTcpStream(peer_addr()andlocal_addr()). Configuration options have to be made available toTcpStreamin order to enforcehttp_info.HttpConnectionis added to achieve this.Fixes #2833
Ps: Rust and oss newbie so apologies if I missed some obvious issue 😅