Skip to content

feat(client): Add system proxy support for macOS #172 #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

andrzejSulkowski
Copy link

cc hyperium/hyper#3850
continued work on PR Draft #171

Because the "system-proxies" introduced quite a few lines of code, I decided to split the matcher.rs into multiple files (builder.rs, matcher.rs, no_proxy.rs, utils.rs)

  • Introduced setter methods for the Builder
  • MacOS System Proxies
    - [ ] Windows System Proxies

Windows System Proxies should be implemented by someone who is using Windows or has a VM to impl. and test the code.

@andrzejSulkowski
Copy link
Author

re-open of #172

@seanmonstar
Copy link
Member

Thanks for re-opening. I tried to make use of this, but I ran into some issues. There were some fairly big merge conflicts, some changes to documentation, and a refactor into many files all included. While I'd welcome discussing any of those, it was hard for me to merge.

So, I created #189 that copies over just a couple functions from reqwest, and otherwise doesn't re-organize the structure.

@andrzejSulkowski
Copy link
Author

Is there anything I can do to help here out. Its a while ago when I worked on this the last time but I could fairly easy get again into the code and look into some issues which came up.

Otherwise we can close this and move on with our lives :)

@seanmonstar
Copy link
Member

I think some of the most useful parts that are still in this branch are the unit tests. Add an inner mac::tests module that tests out a slightly refactor merge_store using a CFDictionary could be helpful.

Up to you, if you want to submit those, feel free to open a new PR with just those changes. Thanks!

@seanmonstar seanmonstar closed this May 6, 2025
@andrzejSulkowski
Copy link
Author

Could you be please more specific?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants