Skip to content

Add Full #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2021
Merged

Add Full #40

merged 3 commits into from
Apr 6, 2021

Conversation

tesaguri
Copy link
Contributor

This implements a part of hyperium/hyper#2345.

This implements Clone and, for example, a client can clone it to retry requests (e.g. for redirections).

davidpdrsn
davidpdrsn approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@davidpdrsn davidpdrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I'm not totally sold on the name Full but I guess as the counterpart of Empty it does make sense 🤔

seanmonstar
seanmonstar reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition to me. The name Full feels fine to me, I took Full as the variant name internally after looking in Netty (FullHttpRequest, FullHttpResponse).

@seanmonstar seanmonstar merged commit e5bd0d1 into hyperium:master Apr 6, 2021
@tesaguri tesaguri deleted the full branch April 6, 2021 22:43
BenxiangGe pushed a commit to BenxiangGe/http-body that referenced this pull request Jul 26, 2021
@tesaguri
Add Full (hyperium#40)
1b938db 
This adds a "full body" type that implements `Body` for a single full buffer, suggesting the body won't be streaming but it already all in memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpdrsn davidpdrsn davidpdrsn approved these changes

@seanmonstar seanmonstar seanmonstar approved these changes

@LucioFranco LucioFranco Awaiting requested review from LucioFranco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesaguri @seanmonstar @davidpdrsn