Skip to content

Conversation

ESHARK22
Copy link
Contributor

@ESHARK22 ESHARK22 commented Oct 1, 2025

🤷‍♂️

@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 13:12
@github-actions github-actions bot added the feat label Oct 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors hardcoded server ping response data into a configurable Bevy resource, making the server description and max player count customizable through the ServerPingResponse resource instead of being embedded directly in the code.

  • Introduces ServerPingResponse struct as a Bevy resource to hold server ping data
  • Replaces hardcoded values in the status request handler with resource data
  • Registers the new resource in the plugin initialization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ESHARK22 ESHARK22 force-pushed the main branch 2 times, most recently from 1786e56 to a40fcbe Compare October 1, 2025 16:16
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.28%. Comparing base (1f28877) to head (ba01e1c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/hyperion/src/ingress/mod.rs 84.61% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   23.22%   23.28%   +0.05%     
==========================================
  Files         157      157              
  Lines       15494    15505      +11     
  Branches      486      486              
==========================================
+ Hits         3599     3610      +11     
  Misses      11794    11794              
  Partials      101      101              
Files with missing lines Coverage Δ
crates/hyperion/src/ingress/mod.rs 24.53% <84.61%> (+4.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TestingPlant TestingPlant added this pull request to the merge queue Oct 6, 2025
Merged via the queue into hyperion-mc:main with commit 313503c Oct 6, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants