-
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Make server ping response data a resource #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors hardcoded server ping response data into a configurable Bevy resource, making the server description and max player count customizable through the ServerPingResponse
resource instead of being embedded directly in the code.
- Introduces
ServerPingResponse
struct as a Bevy resource to hold server ping data - Replaces hardcoded values in the status request handler with resource data
- Registers the new resource in the plugin initialization
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1786e56
to
a40fcbe
Compare
Co-authored-by: TestingPlant <[email protected]>
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #948 +/- ##
==========================================
+ Coverage 23.22% 23.28% +0.05%
==========================================
Files 157 157
Lines 15494 15505 +11
Branches 486 486
==========================================
+ Hits 3599 3610 +11
Misses 11794 11794
Partials 101 101
🚀 New features to boost your workflow:
|
🤷♂️