-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix(dependabot): disable on rust code #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmark Results for general
Comparing to bdac910 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 17.70% 17.70%
=======================================
Files 161 161
Lines 15984 15984
Branches 489 489
=======================================
Hits 2830 2830
- Misses 13086 13087 +1
+ Partials 68 67 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
You can tell dependabot to ignore a dependency. Why not just do that? |
I've tried to do that here: #911 (comment) It still tried to update glam in a PR that was opened a few hours after I used the ignore command. Glam was still in the ignore conditions: #918 (comment) Should I try putting the ignore in the dependabot.yml fild? I'm not too familiar with using dependabot. |
Weird. Must be an upstream bug. Still, I do think that keeping deps up to date is valuable -- I've spent way too much time updating dependencies in big batches rather than gradual small updates. Over in biome we use renovate instead of dependabot, and its done pretty good. Maybe we try that instead? |
I'm currently more focused on other issues, and I'm not too concerned about outdated dependencies at the moment. Feel free to help configure renovate though if you'd like. I'm not familiar with setting up either dependabot or renovate. |
Sure, I can take a look if I have time. |
Dependabot is currently causing issues by trying to update
glam
to a new major release (0.29 -> 0.30) automatically. Dependabot is not that useful because we can always update dependencies as needed for bug fixes and new features.