Skip to content

Conversation

TestingPlant
Copy link
Collaborator

Dependabot is currently causing issues by trying to update glam to a new major release (0.29 -> 0.30) automatically. Dependabot is not that useful because we can always update dependencies as needed for bug fixes and new features.

@github-actions github-actions bot added the fix label Jul 16, 2025
Copy link

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  19.1 ns ...  19.1 ns ]      +0.07%
ray_intersection/aabb_size_1                       [  19.1 ns ...  19.1 ns ]      -0.12%
ray_intersection/aabb_size_10                      [  19.1 ns ...  19.2 ns ]      +0.61%
ray_intersection/ray_distance_1                    [   3.8 ns ...   3.8 ns ]      +0.09%
ray_intersection/ray_distance_5                    [   3.8 ns ...   3.8 ns ]      -0.02%
ray_intersection/ray_distance_20                   [   3.8 ns ...   3.8 ns ]      +0.08%
overlap/no_overlap                                 [  28.8 ns ...  28.9 ns ]      +0.17%
overlap/partial_overlap                            [  28.9 ns ...  28.8 ns ]      -0.20%
overlap/full_containment                           [  21.6 ns ...  21.6 ns ]      -0.15%
point_containment/inside                           [   5.1 ns ...   5.1 ns ]      +0.02%
point_containment/outside                          [   4.4 ns ...   4.4 ns ]      -0.03%
point_containment/boundary                         [   5.0 ns ...   5.0 ns ]      -0.58%

Comparing to bdac910

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.70%. Comparing base (bdac910) to head (0f0a84d).

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   17.70%   17.70%           
=======================================
  Files         161      161           
  Lines       15984    15984           
  Branches      489      489           
=======================================
  Hits         2830     2830           
- Misses      13086    13087    +1     
+ Partials       68       67    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dyc3
Copy link
Contributor

dyc3 commented Jul 16, 2025

You can tell dependabot to ignore a dependency. Why not just do that?

@TestingPlant
Copy link
Collaborator Author

You can tell dependabot to ignore a dependency. Why not just do that?

I've tried to do that here: #911 (comment)

It still tried to update glam in a PR that was opened a few hours after I used the ignore command. Glam was still in the ignore conditions: #918 (comment)

Should I try putting the ignore in the dependabot.yml fild? I'm not too familiar with using dependabot.

@dyc3
Copy link
Contributor

dyc3 commented Jul 17, 2025

Weird. Must be an upstream bug.

Still, I do think that keeping deps up to date is valuable -- I've spent way too much time updating dependencies in big batches rather than gradual small updates. Over in biome we use renovate instead of dependabot, and its done pretty good. Maybe we try that instead?

@TestingPlant
Copy link
Collaborator Author

I'm currently more focused on other issues, and I'm not too concerned about outdated dependencies at the moment. Feel free to help configure renovate though if you'd like. I'm not familiar with setting up either dependabot or renovate.

@dyc3
Copy link
Contributor

dyc3 commented Jul 21, 2025

Sure, I can take a look if I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants