-
-
Notifications
You must be signed in to change notification settings - Fork 32
fix: respawn #917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
TestingPlant
wants to merge
2
commits into
main
Choose a base branch
from
testingplant/fix-respawn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix: respawn #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Player positions are updated immediately when TeleportEvent is sent instead of later when the player confirms the teleportation. This allows the new position to be immediately replicated to other clients, which is also useful to allow the anticheat to continue working even if the client does not acknowledge the teleportation quickly. This also fixes a bug where a player's teleport is not synced with other players because last_tick_position is set to the current position every tick, meaning that the server will continue sending position deltas relative to the previous location instead of the full position to the teleport location.
The tag event already handles respawn. There is no need to have a second respawn handler
Benchmark Results for general
Comparing to bdac910 |
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 17.70% 17.63% -0.07%
==========================================
Files 161 160 -1
Lines 15984 16039 +55
Branches 489 487 -2
==========================================
- Hits 2830 2829 -1
- Misses 13086 13143 +57
+ Partials 68 67 -1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
I need to refactor this so there is a point in time where a player's Position component can be trusted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Player positions are updated immediately when TeleportEvent is sent instead of later when the player confirms the teleportation. This allows the new position to be immediately replicated to other clients, which is also useful to allow the anticheat to continue working even if the client does not acknowledge the teleportation quickly.
This also fixes a bug where a player's teleport is not synced with other players because last_tick_position is set to the current position every tick, meaning that the server will continue sending position deltas relative to the previous location instead of the full position to the teleport location.
The hyperion-respawn plugin was also removed because it is not necessary since attack.rs already handles respawn