Skip to content

fix: Serve external resources like icons and fonts locally #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

MiguelRipoll23
Copy link

I covered the most important resources needed by the app. Currently the stylesheet for Bootstrap icons blocks the page for too long until a timeout is received.

  • Added stylesheet for Bootstrap icons font in public/styles
  • Added stylesheet for Google fonts in public/styles
  • Added font resources in woff and woff2 format in public/fonts
  • Updated references (app.scss, preview-head.html)

I partially tested this PR, I couldn't get the page to load completely in GitHub Codespaces so sorry about that!

Fixes #813

Added IBM Plex Mono font files (Bold, Light, Medium, Regular, and SemiBold) to the public/fonts directory for use in the application.
Removed outdated IBM Plex Mono TTF font files and added updated WOFF2 versions for better performance and compatibility. Also added Bootstrap Icons font files in WOFF and WOFF2 formats.
Updated the font file paths in bootstrap-icons.css to use the correct relative path. This ensures the fonts are loaded properly from the correct directory.
Replaced external links for Bootstrap icons and IBM Plex Mono font with local assets to improve loading performance and reduce dependency on external resources.
Added Roboto v47 font files (weights: 100, 300, 500, 700, and regular) in WOFF2 format to the public/fonts directory for use in the application.
Added Inter font files (100 and 500 weights) in WOFF2 format to the public/fonts directory for use in the application.
Added Roboto Mono font files (weights 100 and 700) to the public/fonts directory for use in the application.
Removed the Inter font file for weight 500 and added the Inter font file for weight 900 in the public/fonts directory.
Removed query parameters from font URLs in bootstrap-icons.css to simplify the file paths and ensure compatibility.
Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: 0c9b9a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 15, 2025

@MiguelRipoll23 is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2025 8:20pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serve external resources like icons and fonts locally
1 participant