Skip to content

Serve external resources like icons and fonts locally #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MiguelRipoll23 opened this issue May 14, 2025 · 2 comments · May be fixed by #818
Open

Serve external resources like icons and fonts locally #813

MiguelRipoll23 opened this issue May 14, 2025 · 2 comments · May be fixed by #818

Comments

@MiguelRipoll23
Copy link

Some resources like icons and fonts are loading externally which means offline servers or protected networks can't load the web UI properly, would it be possible to bundle these resources and serve them locally?

Thanks!
@MikeShi42
Copy link
Contributor

It wouldn't be hard I believe - we just need to move the assets into the /public folder under the app and then change our resources to point there instead. Open to any contributions as this should be relatively straightforward of a fix :)

@MiguelRipoll23
Copy link
Author

That’s great! I will submit a PR then.

I’ll copy the resources to the public directory and update the references:

https://github.com/hyperdxio/hyperdx/blob/main/packages/app/.storybook/preview-head.html

@MiguelRipoll23 MiguelRipoll23 linked a pull request May 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Serve external resources like icons and fonts locally MiguelRipoll23/hyperdx
2 participants
@MikeShi42 @MiguelRipoll23