fix!: update BungeeCord to v1.20-R0.3-SNAPSHOT and fix StaffJoinEvent #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BungeeCord broke their API by changing the PostLoginEvent to an AsyncEvent and adding a new field (which breaks the lombok `@Data` constructor): SpigotMC/BungeeCord@17e23d5 BREAKING CHANGE: StaffJoinEvent no longer extends the BungeeCord PostLoginEvent. This change should not break any plugins using the API unless they are attempting to use the StaffJoinEvent as a PostLoginEvent (e.g. by casting), however this is not recommended.
joshuasing
added
type: dependencies
LooFifteen
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update BungeeCord to
1.20-R0.3-SNAPSHOTand fix StaffJoinEvent.BungeeCord broke their API by changing the PostLoginEvent to an AsyncEvent and adding a new field (which breaks the lombok
@Dataconstructor, thus breaking StaffJoinEvent): SpigotMC/BungeeCord@17e23d5Changes
bungeecord-apito1.20-R0.3-SNAPSHOTStaffJoinEventto no longer extendPostLoginEventand addgetPlayer()method toStaffJoinEvent(instead of using the method fromPostLoginEvent).Checklist
Breaking change
StaffJoinEventno longer extends the BungeeCordPostLoginEventclass.This change should not break any plugins using the API unless they are attempting to use the
StaffJoinEventas aPostLoginEvent(e.g. by casting), which is unlikely and is not recommended.Due to this breakage originally being caused by BungeeCord, and the unlikeliness of an API user requiring
StaffJoinEventto extendPostLoginEvent, this change will be released in v5.2.2 and no major version bump will occur.It is highly unlikely that this will actually break anything using the API.