build: bundle patched ghostty-opentui into dist#95
Merged
Conversation
patchedDependencies aren't transitive — npm consumers get the unpatched version. Replace the inline build command with a build.ts script that uses a Bun plugin to bundle the patched terminal-buffer code while keeping the native FFI module external. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
🎉 This PR is included in version 2.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patchedDependenciesaren't transitive — npm consumers would get the unpatchedghostty-opentui, hitting thelogicalLineInfocrashbun buildCLI command with abuild.tsscript using a Bun plugin that bundles the patchedterminal-buffercode while keeping the native FFI module externalghostty-opentuipackage at runtimeTest plan
bun run buildsucceedslineInfo?.lineStarts,if (lineInfo)guard) present indist/numux.jsfrom "ghostty-opentui") — no.nodeassets in dist🤖 Generated with Claude Code