fix: patch ghostty-opentui dist/ for logicalLineInfo crash#94
Merged
Conversation
The existing patch only covered src/ but Bun can resolve to dist/ in some setups. Also print stack traces instead of just messages in unhandled rejection handlers. Upstream: remorses/ghostty-opentui#15 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ghostty-opentuipatch to also coverdist/terminal-buffer.js— the existing patch only fixedsrc/but Bun can resolve todist/in some setups, leaving thelogicalLineInfonull guard unappliedUpstream fix: remorses/ghostty-opentui#15
Test plan
logicalLineInfocrash — should no longer crashbun installapplies the patch cleanly to bothsrc/anddist/🤖 Generated with Claude Code