fix: guard against undefined lineInfo crash#89
Merged
Conversation
Update @opentui/core (0.1.81→0.1.88) which fixes the lineInfo crash in ScrollBox.scrollHeight/scrollWidth. Update ghostty-opentui (1.4.3→1.4.7) and patch its remaining unguarded lineInfo access in renderSelf and getScrollPositionForLine. Also move stderr error messages inside app.shutdown().finally() so they print after TUI teardown and are actually visible. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@opentui/core(0.1.81→0.1.88) which fixeslineInfo.lineStartscrash inScrollBox.scrollHeight/scrollWidthghostty-opentui(1.4.3→1.4.7) and patch remaining unguardedlineInfoaccess inrenderSelfandgetScrollPositionForLineapp.shutdown().finally()so crash messages print after TUI teardown and are visibleTest plan
bun run typecheckpassesbun test— 599 tests passlineInfocrash on startup🤖 Generated with Claude Code