Skip to content

chore(backend): Remove redundant row-major op entries#1331

Merged
Hzfengsy merged 1 commit into
hw-native-sys:mainfrom
lwDavid:cleanup-row-major-ops
May 12, 2026
Merged

chore(backend): Remove redundant row-major op entries#1331
Hzfengsy merged 1 commit into
hw-native-sys:mainfrom
lwDavid:cleanup-row-major-ops

Conversation

@lwDavid
Copy link
Copy Markdown
Contributor

@lwDavid lwDavid commented May 11, 2026

Summary

  • Remove redundant tile.sel and tile.rsqrt entries from RequiresRowMajorLayout::kRowMajorOps
  • Keep their row-major layout requirements in their existing custom registrations

Validation

  • git diff --check
  • clang-format --dry-run --Werror src/backend/common/pto_ops_common.cpp
  • python tests/lint/clang_tidy.py --diff-base HEAD

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a5db69b6-467d-4cd5-89bc-0397fe3494b2

📥 Commits

Reviewing files that changed from the base of the PR and between e2e9257 and bb238b4.

📒 Files selected for processing (1)
  • src/backend/common/pto_ops_common.cpp
💤 Files with no reviewable changes (1)
  • src/backend/common/pto_ops_common.cpp

📝 Walkthrough

Walkthrough

This PR removes tile.sel from the RequiresRowMajorLayout() allowlist in pto_ops_common.cpp. The op will no longer be auto-configured by generic N-ary op layout logic and instead continues via its dedicated registration path with explicit layout settings.

Changes

Layout Configuration Delegation

Layer / File(s) Summary
Remove tile.sel from row-major layout allowlist
src/backend/common/pto_ops_common.cpp
tile.sel removed from RequiresRowMajorLayout() allowlist; generic layout auto-configuration no longer applies, delegating handling to dedicated tile.sel registration path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • hw-native-sys/pypto#1231: Adds/modifies ResolveBackendOpLayouts repair logic that acts on ops flagged by RequiresRowMajorLayout(), which this PR modifies.
  • hw-native-sys/pypto#729: Previously modified RequiresRowMajorLayout() and tile.sel registration handling in similar ways.

Suggested reviewers

  • lyfne123
  • Hzfengsy

Poem

🐰 A small hop through layout land,
tile.sel takes a different strand,
No more auto-config today,
Dedicated registration finds its way! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: removing redundant row-major op entries from the codebase.
Description check ✅ Passed The description clearly explains what was removed and why, with specific op names and validation steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lwDavid lwDavid self-assigned this May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates src/backend/common/pto_ops_common.cpp by removing tile.sel and tile.rsqrt from the list of operations requiring a row-major layout. I have no feedback to provide as no review comments were submitted.

@lwDavid lwDavid requested a review from lyfne123 May 12, 2026 01:35
@Hzfengsy Hzfengsy merged commit 2f76f2f into hw-native-sys:main May 12, 2026
9 checks passed
@lwDavid lwDavid moved this to Done in pto project May 12, 2026
@lwDavid lwDavid added the Simple label May 12, 2026
@lwDavid lwDavid deleted the cleanup-row-major-ops branch May 13, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants