Skip to content

Fix TileLang DSL textract and tsels tests#815

Open
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:codex/fix-tilelang-dsl-ci-main
Open

Fix TileLang DSL textract and tsels tests#815
mouliangyu wants to merge 1 commit into
hw-native-sys:mainfrom
mouliangyu:codex/fix-tilelang-dsl-ci-main

Conversation

@mouliangyu

Copy link
Copy Markdown
Contributor

Summary

  • fix textract mat2right golden generation to match the simulator output layout
  • model tsels f32 scalars as native f32 operands in the testcase PTO so host/device ABI stays consistent

Validation

  • python3 /tmp/PTOAS-upstream/test/tilelang_st/script/run_st.py -r sim -v a5 -t textract -p /tmp/PTOAS-upstream/build/tools/ptoas/ptoas
  • python3 /tmp/PTOAS-upstream/test/tilelang_st/script/run_st.py -r sim -v a5 -t tsels -p /tmp/PTOAS-upstream/build/tools/ptoas/ptoas

@mouliangyu mouliangyu marked this pull request as ready for review June 14, 2026 16:28

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the golden data generation in gen_data.py by transposing and copying the source array directly instead of multiplying it by an identity matrix. In tsels.pto, the %scalar parameter type is updated from i32 to f32 across several kernel functions, eliminating the need for redundant arith.bitcast operations. Since there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@reedhecre

reedhecre commented Jun 14, 2026

Copy link
Copy Markdown

Codex Review

该评论由 review 机器人自动更新。

  • PR: Fix TileLang DSL textract and tsels tests #815 Fix TileLang DSL textract and tsels tests
  • Author: mouliangyu
  • Base/Head: main / codex/fix-tilelang-dsl-ci-main
  • Head SHA: 41d05e5aba9b
  • Trigger: 检测到新的 open PR
  • Generated At: 2026-06-14T16:31:13Z
  • Status: failed at codex-review (exit=1)

Summary

Review failed at stage codex-review: exit=1

Findings

未生成结构化 findings,因为 review 过程提前失败。

Log Tail


===== STAGE clone @ 2026-06-15 00:30:32 =====
set -euo pipefail
rm -rf '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo'
git clone --branch 'main' --depth 50 'https://github.com/hw-native-sys/PTOAS.git' '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo'
cd '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo'
git fetch origin 'refs/pull/815/head:pr-815' --depth 50
git fetch origin 'main' --depth 50 || true
git checkout -f 'pr-815'
git rev-parse HEAD
git diff --stat 'origin/main...HEAD' || true
Cloning into '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo'...
From https://github.com/hw-native-sys/PTOAS
 * [new ref]         refs/pull/815/head -> pr-815
From https://github.com/hw-native-sys/PTOAS
 * branch            main       -> FETCH_HEAD
Switched to branch 'pr-815'
41d05e5aba9b0f20076e19afa05d690725366a92
 .../npu/a5/src/st/testcase/textract/gen_data.py    |  4 +--
 .../npu/a5/src/st/testcase/tsels/tsels.pto         | 32 +++++++++-------------
 2 files changed, 15 insertions(+), 21 deletions(-)
===== END STAGE clone rc=0 @ 2026-06-15 00:30:37 =====

===== STAGE codex-review @ 2026-06-15 00:30:37 =====
set -euo pipefail
cd '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo'
'codex' exec -C '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo' -s read-only -c 'model_provider="codereview"' -c 'model="gpt-5.4"' -c 'model_reasoning_effort="xhigh"' --output-schema '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/review_schema.json' -o '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/codex_last_message.json' --color never - < '/tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/review_prompt.txt'
OpenAI Codex v0.115.0 (research preview)
--------
workdir: /tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/repo
model: gpt-5.4
provider: codereview
approval: never
sandbox: read-only
reasoning effort: xhigh
reasoning summaries: none
session id: 019ec6f8-8fa1-7042-8cc5-c5a74beb702c
--------
user
你现在在审查 GitHub PR。

仓库:hw-native-sys/PTOAS
PR:#815 Fix TileLang DSL textract and tsels tests
作者:mouliangyu
base branch:origin/main
head branch:HEAD(当前已 checkout 到 PR head)

要求:
1. 只审查这个 PR 相对 origin/main 的改动,必要时可以看上下文文件。
2. 重点找真实的 correctness / regression / contract mismatch / CI / runtime / compatibility 问题。
3. 不要提纯风格建议,不要提低价值猜测。
4. 严格按优先级输出:
   - P1:高概率会导致错误结果、编译/运行失败、严重回归、发布阻断
   - P2:重要缺陷、行为回归、遗漏校验/测试、较大兼容性问题
   - P3:次要但明确可改的问题
5. 如果没有问题,summary 直接写:未检查到 PR #815 存在问题,并返回 findings=[]。
6. 如果有问题,summary 简洁概括,findings 里每条都要给出:
   - severity
   - title
   - body(说明为什么是问题,尽量具体)
   - file(尽量给相对路径)
   - line(能确定就填整数,否则 null)

建议先查看:
- git status --short
- git diff --stat origin/main...HEAD
- git diff --unified=80 origin/main...HEAD

最终输出必须严格匹配 JSON schema。

mcp startup: no servers
Reconnecting... 1/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 1bf8d40c-97a2-4710-a828-09a8cb1fc42b)
Reconnecting... 2/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: c1ff1067-db16-4ad4-ba00-0b922edb556f)
Reconnecting... 3/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 9bd997d6-0879-4785-91c6-26fc9e0d7e0c)
Reconnecting... 4/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 5de0d1dd-ff15-4a5d-b79d-7cab8144e5d5)
Reconnecting... 5/5 (unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: 9aab2c2d-b4d0-4b0e-a8ec-b49955a45c84)
ERROR: unexpected status 503 Service Unavailable: Service temporarily unavailable, url: https://codex.0u0o.com/responses, request id: cedeceee-c97b-470e-b9ba-3a8e1611df08
Warning: no last agent message; wrote empty content to /tmp/ptoas-pr-review-monitor/runs/20260615_003031_pr815/codex_last_message.json
===== END STAGE codex-review rc=1 @ 2026-06-15 00:31:13 =====

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants