Fix TileLang DSL textract and tsels tests#815
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies the golden data generation in gen_data.py by transposing and copying the source array directly instead of multiplying it by an identity matrix. In tsels.pto, the %scalar parameter type is updated from i32 to f32 across several kernel functions, eliminating the need for redundant arith.bitcast operations. Since there are no review comments, I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings,因为 review 过程提前失败。 Log Tail |
Summary
textractmat2right golden generation to match the simulator output layouttselsf32 scalars as nativef32operands in the testcase PTO so host/device ABI stays consistentValidation
python3 /tmp/PTOAS-upstream/test/tilelang_st/script/run_st.py -r sim -v a5 -t textract -p /tmp/PTOAS-upstream/build/tools/ptoas/ptoaspython3 /tmp/PTOAS-upstream/test/tilelang_st/script/run_st.py -r sim -v a5 -t tsels -p /tmp/PTOAS-upstream/build/tools/ptoas/ptoas