Fix PTOAS warning build failures#675
Merged
zhangstevenunity merged 3 commits intoMay 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several code cleanups and robustness improvements, including the addition of [[maybe_unused]] attributes to suppress compiler warnings, the removal of unnecessary lambda captures, and the refactoring of switch statements to move default return values outside the blocks. Additionally, stringifyLocFromMemorySpace was updated with a null check and new address space mappings. Feedback was provided regarding the mapping of AddressSpace::Zero to "illegal", which may cause issues with IR round-tripping since it is treated as a valid memory space elsewhere in the codebase.
| if (!asAttr) | ||
| return "illegal"; | ||
| switch (asAttr.getAddressSpace()) { | ||
| case AddressSpace::Zero: return "illegal"; |
Codex Review该评论由 review 机器人自动更新。
Summary未检查到 PR #675 存在问题 FindingsNo issues found. |
5aca246 to
2d79268
Compare
8de3d31 to
460cafc
Compare
A5 板测成功
|
A3 板测完成(有跳过)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 macOS/Clang 和gitcode/gcc下 ninja -C build install 的 -Werror 构建失败。
主要清理了几处会被 Clang 视为错误的编译告警: