-
Notifications
You must be signed in to change notification settings - Fork 50
feat(pto-gss): add A5 buf-id sync emission style to GraphSyncSolver #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhangstevenunity
wants to merge
10
commits into
main
Choose a base branch
from
claude/heuristic-greider-a67dd3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4cdc66c
feat(pto-gss): add A5 buf-id sync emission style to GraphSyncSolver
zhangstevenunity 8ceed96
fix(pto-gss): drop backward ConflictPair brackets in buf-id mode
zhangstevenunity bffa5b8
fix(pto-gss): buffer-aware id grouping for buf-id loop sync
zhangstevenunity de7fe04
fix(pto-gss): anchor buf-id brackets at raw RWOp, not solver's hoiste…
zhangstevenunity 1406fcd
test(pto-gss): buf-id branch coverage for consumer-inside-if
zhangstevenunity 780ad32
test(pto-gss): buf-id cross-loop dependency coverage
zhangstevenunity f715667
fix(pto-gss): allow buf-id pairs in mutually exclusive if-branches to…
zhangstevenunity 829945f
fix(pto-gss): plumb buffer info through ConflictPair for buf-id trans…
zhangstevenunity 448f34e
fix(pto-gss): mutex-branch aware checkGraphConflict pruning for buf-id
zhangstevenunity 026c26a
Update ptoas-graph-sync-solver-buf-id-design.md
zhangstevenunity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
buf-idis selected here, same-pipe hazards are still sent through the existinghandleBarrierConflictpath; that path only suppresses A5 barriers forPIPE_V/PIPE_M, so legal A5 cases such as twoTLOAD/MTE2 operations on the same buffer can still producepto.barriereven though this option and the pass docs promise that buf-id/A5 emits no barriers. This makes the new mode generate unsupported/unwanted sync for same-pipe MTE2/MTE3/FIX conflicts unless the option also disables barrier conflicts for all pipes in buf-id mode.Useful? React with 👍 / 👎.