Skip to content

PR for updated halophot#17

Open
JonatanRudrasingam wants to merge 18 commits into
stablefrom
jr_develop
Open

PR for updated halophot#17
JonatanRudrasingam wants to merge 18 commits into
stablefrom
jr_develop

Conversation

@JonatanRudrasingam

@JonatanRudrasingam JonatanRudrasingam commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator
  • Analyze CI failure: python setup.py install doesn't install install_requires deps
  • Add tqdm to requirements.txt (it's imported in halo_tools.py but was missing)
  • Remove k2sc from requirements.txt (installed separately from GitHub in CI; avoids PyPI lookup failures)
  • Remove pybind11 from requirements.txt (build tool, not a runtime dependency)
  • Update CI workflow: add pip install -r requirements.txt step and replace python setup.py install with pip install --no-deps .

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@benjaminpope

Copy link
Copy Markdown
Collaborator

@copilot fix the dependencies issues - it is currently failing with

from statsmodels.nonparametric.bandwidths import select_bandwidth
E   ModuleNotFoundError: No module named 'statsmodels'

Search for any other dependency issues and edit this PR to fix them.

… step

Agent-Logs-Url: https://github.com/hvidy/halophot/sessions/63ced909-ab7e-425b-8ea0-0a2051f9ee48

Co-authored-by: benjaminpope <6024213+benjaminpope@users.noreply.github.com>

Copilot AI commented Mar 30, 2026

Copy link
Copy Markdown

@copilot fix the dependencies issues - it is currently failing with

from statsmodels.nonparametric.bandwidths import select_bandwidth

...

Fixed in commit fa6ea0b. The root cause was that python setup.py install in newer setuptools no longer installs install_requires dependencies — so statsmodels and other packages were never being installed.

Changes made:

  1. CI workflow (github-workflow.yml): Added an explicit pip install -r requirements.txt step and replaced python setup.py install with pip install --no-deps .
  2. requirements.txt: Added missing tqdm (imported in halo_tools.py but was absent), removed k2sc (already installed from GitHub in a separate CI step), and removed pybind11 (build tool, not a runtime dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants