Fix Early Exit caused by Folder Detection#126
Open
nichxlxs wants to merge 3 commits intohuntresslabs:mainfrom
Open
Fix Early Exit caused by Folder Detection#126nichxlxs wants to merge 3 commits intohuntresslabs:mainfrom
nichxlxs wants to merge 3 commits intohuntresslabs:mainfrom
Conversation
This will cause an early exit as the failed installer logs are stored in this folder. Instead, we should check if the executable exists.
This will cause an early exit as the failed installer logs are stored in this folder. Instead, we should check if the executable exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the huntress installer script fails, it will leave a log file in the Huntress folder. If you run the job again, it will exit early as it has 'detected' that huntress was already installed since the folder exists.
Instead, it should check if the executable is there.
Additionally, there are multiple checks that happen before this which does confirm if Huntress is already installed, so I don't think this one is really needed. However, it does give extra output saying to use re-register or reinstall flags.