Skip to content

Fix pagination issue with migrate wp authors CLI command. #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattheu wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix pagination issue with migrate wp authors CLI command. #121

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dc23c86
Fix migrate authors query pagination
mattheu Jan 19, 2023
baedf57
Update comment
mattheu Mar 3, 2023
8faa8f6
Merge remote-tracking branch 'origin/main' into fix-migrate-authors-q…
mattheu Sep 4, 2023
51504c2
Add unit test for pagination when overwriting
mattheu Sep 4, 2023
f4fd257
Fix correct post ID vs post object
mattheu Sep 4, 2023
3f768a6
Set default value
mattheu Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion inc/cli/class-migrate-command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,11 @@ public function wp_authors( $args, $assoc_args ) : void {
WP_CLI::line( sprintf( 'Processed %d posts, pausing for a breath...', $count ) );
sleep( 2 );

$paged++;
// When not overwriting, or during a dry run,
// need to skip pagination due to NOT EXISTS tax query.
if ( $dry_run || $overwrite ) {
$paged++;
}
} while ( count( $posts ) );

if ( true === $dry_run ) {
Expand Down